fix: compilation with --no-default-features#593
Merged
alexhancock merged 1 commit intomodelcontextprotocol:mainfrom Feb 4, 2026
Merged
fix: compilation with --no-default-features#593alexhancock merged 1 commit intomodelcontextprotocol:mainfrom
alexhancock merged 1 commit intomodelcontextprotocol:mainfrom
Conversation
github-actions
bot
added
T-dependencies
scutuatua-crypto
approved these changes
Jan 10, 2026
Collaborator
|
@Vaiz LGTM. If you can adjust the commit message to follow https://www.conventionalcommits.org/en/v1.0.0/ we can merge I am also going to add a pre-commit hook for this. |
Contributor
Author
@alexhancock , thanks for looking into that. |
alexhancock
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is a pretty simple change that fixes feature gates in a couple of places. It allows to use
rmcpcrate in server mode without enablingmacrosandbase64features reducing the dependency tree for applications that don't use those capabilities.How Has This Been Tested?
I verified that it actually compiles now
cargo build -p rmcp --no-default-features --features serverBreaking Changes
There are no breaking changes
Types of changes
Checklist